MSI installer #38
MSI installer #38
Conversation
…or Windows Server 2016. Fixes #34
| // You can specify all the values or you can default the Build and Revision Numbers | ||
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] |
There was a problem hiding this comment.
These are not updated during the build, something to look into during the beta (should we set these to 0.0.0.1 for the moment?
There was a problem hiding this comment.
I had ripped out the AssemblyInfo patching, but I might just add it back in.
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
There was a problem hiding this comment.
We don't use [CustomAction] is this file still needed?
There was a problem hiding this comment.
Will remove if I can.
installer/paket.dependencies
Outdated
|
|
||
| source https://www.nuget.org/api/v2 | ||
|
|
||
| nuget xunit |
There was a problem hiding this comment.
This could be cleaned up to only include the things needed for this project (e.g xunit and fluentassertions are not needed AFAIK)
There was a problem hiding this comment.
I've left some comments.
It also looks like this still has a dependency on Wix Toolset being installed, although it references the nuget package that contains all of the Wix binaries. I think the WixSharp Compiler.WixLocation property needs to be set to the package location, similar to the Elasticsearch Windows installer:
…ompilation process.
| [assembly: AssemblyCopyright("Copyright © 2017")] | ||
| [assembly: AssemblyCompany("Elasticsearch B.V.")] | ||
| [assembly: AssemblyProduct("Elasticsearch ODBC Installer")] | ||
| [assembly: AssemblyCopyright("Copyright Elasticsearch B.V. ©")] |
No description provided.